Use timezone-aware datetime for SSH key cutoff date comparison (#12538)

Copilot · stsewd · web-flow · commit 11a07a1c3198 · 2025-10-29T14:01:40.000-05:00
Addresses feedback from #12536 to use timezone-aware datetime objects in the SSH key write access deprecation check. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stsewd <4975310+stsewd@users.noreply.github.com>
diff --git a/readthedocs/doc_builder/director.py b/readthedocs/doc_builder/director.py
@@ -218,7 +218,8 @@ def checkout(self):
                     {"has_ssh_key_with_write_access": has_ssh_key_with_write_access}
                 )
 
-            hard_failure = datetime.datetime.now() >= datetime.datetime(2025, 12, 1)
+            now = datetime.datetime.now(tz=datetime.timezone.utc)
+            hard_failure = now >= datetime.datetime(2025, 12, 1, 0, 0, 0, tzinfo=datetime.timezone.utc)
             if has_ssh_key_with_write_access:
                 if hard_failure and settings.RTD_ENFORCE_BROWNOUTS_FOR_DEPRECATIONS:
                     raise BuildUserError(BuildUserError.SSH_KEY_WITH_WRITE_ACCESS)

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,8 @@ def checkout(self):`
`218`	`218`	`{"has_ssh_key_with_write_access": has_ssh_key_with_write_access}`
`219`	`219`	`)`
`220`	`220`
`221`		`- hard_failure = datetime.datetime.now() >= datetime.datetime(2025, 12, 1)`
	`221`	`+ now = datetime.datetime.now(tz=datetime.timezone.utc)`
	`222`	`+ hard_failure = now >= datetime.datetime(2025, 12, 1, 0, 0, 0, tzinfo=datetime.timezone.utc)`
`222`	`223`	`if has_ssh_key_with_write_access:`
`223`	`224`	`if hard_failure and settings.RTD_ENFORCE_BROWNOUTS_FOR_DEPRECATIONS:`
`224`	`225`	`raise BuildUserError(BuildUserError.SSH_KEY_WITH_WRITE_ACCESS)`