Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit On GitHub link broken #3994

Closed
SylvainCorlay opened this issue Apr 21, 2018 · 3 comments
Closed

Edit On GitHub link broken #3994

SylvainCorlay opened this issue Apr 21, 2018 · 3 comments
Labels
Bug A bug

Comments

@SylvainCorlay
Copy link

Details

Expected Result

The link "Edit on GitHub" to point a valid URL.

Actual Result

The link "Edit on GitHub" lacks the "blob" part

For example on page https://github.com/QuantStack/xleaflet//master/docs/source/index.rst,

the link points to

https://github.com/QuantStack/xleaflet//master/docs/source/index.rst

instead of

https://github.com/QuantStack/xleaflet/blob/master/docs/source/index.rst

@stsewd stsewd added the Bug A bug label Apr 22, 2018
@stsewd
Copy link
Member

stsewd commented Apr 22, 2018

I think the is kind of related to #3925, I will take a further look later.

@stsewd
Copy link
Member

stsewd commented Apr 23, 2018

This is a bug from the rtd theme, I'm fixing it on readthedocs/sphinx_rtd_theme#617

@stsewd
Copy link
Member

stsewd commented Apr 23, 2018

This should be fixed in the next release of the rtd theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

2 participants