Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings on build #4861

Closed
rajgoesout opened this issue Nov 4, 2018 · 2 comments
Closed

Warnings on build #4861

rajgoesout opened this issue Nov 4, 2018 · 2 comments
Labels
Improvement Minor improvement to code
Milestone

Comments

@rajgoesout
Copy link

rajgoesout commented Nov 4, 2018

Details

Expected Result

Guardian authentication backend must be hooked.

Actual Result

When I am building the database/loading test data/creating superuser/running server;
I'm being shown the following warning:

System check identified some issues:

WARNINGS:
?: (guardian.W001) Guardian authentication backend is not hooked. You can add this in settings as eg: `AUTHENTICATION_BACKENDS = ('django.contrib.auth.backends.ModelBackend', 'guardian.backends.ObjectPermissionBackend')`.

Notes

  • Operating System: macOS Mojave
    Do you want me to work on this issue?
@RichardLitt RichardLitt added the Support Support question label Nov 4, 2018
@dojutsu-user
Copy link
Member

@rajdeepbharati
I don't think RTD is using django-guardian as one of AUTHENTICATION_BACKENDS. It is being used for its other functions/classes - assign, get_object_for_user, GuardedModelAdmin (class).
I grepped all the files, searching for guardian and I found only these uses of it.

Also, AUTHENTICATION_BACKENDS was introduced during the configuration of django-allauth ( #commit), much after the configuration of django-guardian (related commits: #commit1, #commit2)

@stsewd
Copy link
Member

stsewd commented Nov 5, 2018

I think I saw the same warning on production, so this shouldn't be causing any problems.

@agjohnson agjohnson added Improvement Minor improvement to code and removed Support Support question labels Nov 10, 2018
@agjohnson agjohnson added this to the Refactoring milestone Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

5 participants