Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger build on default branch when saving a project #5358

Closed
stsewd opened this issue Feb 27, 2019 · 3 comments
Closed

Trigger build on default branch when saving a project #5358

stsewd opened this issue Feb 27, 2019 · 3 comments
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@stsewd
Copy link
Member

stsewd commented Feb 27, 2019

Currently when we save a project form (admin panel),
it triggers a build to latest

https://github.com/rtfd/readthedocs.org/blob/9874b866fea9696fa8495d7b3699f1bf1a3f923d/readthedocs/projects/forms.py#L69-L74

https://github.com/rtfd/readthedocs.org/blob/9874b866fea9696fa8495d7b3699f1bf1a3f923d/readthedocs/core/utils/__init__.py#L97-L98

Even if latest is deactivated, we should trigger a build to the default branch instead.

@stsewd stsewd added the Bug A bug label Feb 27, 2019
@dojutsu-user
Copy link
Member

@stsewd
I'm working on it.

@dojutsu-user
Copy link
Member

@stsewd
Does the build needs to trigger build for both the default_branch and latest branch ?

@humitos
Copy link
Member

humitos commented Mar 3, 2019

@dojutsu-user I think it should trigger just the default_branch without latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

No branches or pull requests

3 participants