New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate docs dir before writing custom js #5568

Closed

stsewd opened this issue Apr 3, 2019 · 1 comment · Fixed by #5569

Labels

Bug Good First Issue

Member

stsewd commented Apr 3, 2019

If the user puts an invalid docs dir, we fail with a generic error, we should raise a more specific one.

https://github.com/rtfd/readthedocs.org/blob/44951fbf8fe1fe12fa9f99f3075f87bd77188525/readthedocs/doc_builder/backends/mkdocs.py#L175-L176

stsewd added Good First Issue Bug labels

Member

saadmk11 commented Apr 3, 2019

@stsewd Should the validation be here?
https://github.com/rtfd/readthedocs.org/blob/44951fbf8fe1fe12fa9f99f3075f87bd77188525/readthedocs/doc_builder/base.py#L84

or should we put it be before
https://github.com/rtfd/readthedocs.org/blob/44951fbf8fe1fe12fa9f99f3075f87bd77188525/readthedocs/doc_builder/backends/mkdocs.py#L175-L176

saadmk11 mentioned this issue

Validate docs dir before writing custom js #5569

Merged

stsewd closed this as completed in #5569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment