Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move expandable_fields to meta class #6159

Closed
stsewd opened this issue Sep 9, 2019 · 2 comments · Fixed by #6198
Closed

Move expandable_fields to meta class #6159

stsewd opened this issue Sep 9, 2019 · 2 comments · Fixed by #6198
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Sep 9, 2019

We are using the old way, declaring expandable_fields at the class level instead of on the meta class.

Docs on https://github.com/rsinger86/drf-flex-fields

This file needs to be updated https://github.com/readthedocs/readthedocs.org/blob/master/readthedocs/api/v3/serializers.py

Ref #6158 (comment)

@stsewd stsewd added Good First Issue Good for new contributors Improvement Minor improvement to code labels Sep 9, 2019
@Iamshankhadeep
Copy link
Contributor

only the serializers.py needs to be updated?

@stsewd
Copy link
Member Author

stsewd commented Sep 19, 2019

@Iamshankhadeep if you find other files, feel free to update those too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants