Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move automatic Docker limits back to a setting #6983

Closed
3 tasks
agjohnson opened this issue Apr 28, 2020 · 1 comment
Closed
3 tasks

Move automatic Docker limits back to a setting #6983

agjohnson opened this issue Apr 28, 2020 · 1 comment
Labels
Accepted Accepted issue on our roadmap

Comments

@agjohnson
Copy link
Contributor

We have different requirements for limits between community and commercial -- namely we allow a lot more build time by default on commercial. The most explicit version of this would be using the same logic to check memory, but pushed into a @property setting in community/commercial.

Because of the removal of all docker limit settings between community/commercial/ops, the default build time on commercial has dropped.

Also, there is a lot of information squirreled away in the DMI information:
sudo find /sys/devices/virtual/dmi/id/ -type f | sudo xargs -n1 -t cat

This could be of use if we want to detect default settings only when running in production perhaps. Having explicit limits on readthedocsinc.settings.base might be enough.

This was discovered in #6982

@agjohnson agjohnson added Bug A bug Accepted Accepted issue on our roadmap labels Apr 28, 2020
@humitos
Copy link
Member

humitos commented Mar 18, 2021

The most explicit version of this would be using the same logic to check memory, but pushed into a @property setting in community/commercial.

It seems this is already done in #7023

Now it's dynamically calculated based on RAM and using a coefficient to calculate the time. There were some adjustment to that logic over time and I think that it's working as we want now: higher memory and time on commercial than on community.

@humitos humitos removed the Bug A bug label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap
Projects
None yet
Development

No branches or pull requests

2 participants