-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected error after minor changes. #7480
Comments
I think this may be due
We shouldn't pre-install that dep and rely on sphinx or whatever tool to install the correct version of the dependency. We may need to dig a little more and see if sphinx was always requiring that package or the reason why we pinned the package. |
Sphinx declares that dependency in the latest version https://github.com/sphinx-doc/sphinx/blob/bec30596a8f7487cad23df532bf02d1b29024dbc/setup.py#L25 and since 1.0 https://github.com/sphinx-doc/sphinx/blob/690fc257e9a539a4c193ba8efe5587f7c102785c/setup.py#L47 So I think we are safe to remove it. |
But looks like sphinx should work with any 2.x version. |
In the meantime you can try installing |
Thank you for your answer. I was able able to built the doc locally with Pygments 2.7.0 and 2.3.1 (previous install was 2.6.1). To give you an idea, our last successful remote build was 5 days ago so any harmful changes in RTD would have had to occur in the last few days. |
We didn't change anything that could break this, I think it may be related to an unpinned dependency from another library. |
The same issue has been raised on Sphinx (sphinx-doc/sphinx#8198). It seems that pinning Pygments did indeed fix the issue for some. I'll go ahead and try to make a remote build doing this. |
Pinning Thanks a lot for your time and help! |
Details
Expected Result
We expected a successful doc build. Changes from the last successful built were minimal, no package were updated and the doc can be built locally without warning or errors with up-to-date dependencies.
Actual Result
An unexpected error got raised:
AssertionError: wrong color format 'var(--jp-mirror-editor-variable-color)'
A very similar issue has been raised by other users recently as seen here.
The text was updated successfully, but these errors were encountered: