Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected error after minor changes. #7480

Closed
QLutz opened this issue Sep 14, 2020 · 8 comments
Closed

Unexpected error after minor changes. #7480

QLutz opened this issue Sep 14, 2020 · 8 comments
Labels
Support Support question

Comments

@QLutz
Copy link

QLutz commented Sep 14, 2020

Details

Expected Result

We expected a successful doc build. Changes from the last successful built were minimal, no package were updated and the doc can be built locally without warning or errors with up-to-date dependencies.

Actual Result

An unexpected error got raised:
AssertionError: wrong color format 'var(--jp-mirror-editor-variable-color)'

A very similar issue has been raised by other users recently as seen here.

@stsewd
Copy link
Member

stsewd commented Sep 14, 2020

I think this may be due

We shouldn't pre-install that dep and rely on sphinx or whatever tool to install the correct version of the dependency. We may need to dig a little more and see if sphinx was always requiring that package or the reason why we pinned the package.

@stsewd
Copy link
Member

stsewd commented Sep 14, 2020

@stsewd
Copy link
Member

stsewd commented Sep 14, 2020

But looks like sphinx should work with any 2.x version.

@stsewd
Copy link
Member

stsewd commented Sep 14, 2020

In the meantime you can try installing Pyments==2.7.0 in your dependencies.

@QLutz
Copy link
Author

QLutz commented Sep 14, 2020

Thank you for your answer.

I was able able to built the doc locally with Pygments 2.7.0 and 2.3.1 (previous install was 2.6.1).

To give you an idea, our last successful remote build was 5 days ago so any harmful changes in RTD would have had to occur in the last few days.

@stsewd
Copy link
Member

stsewd commented Sep 17, 2020

We didn't change anything that could break this, I think it may be related to an unpinned dependency from another library.

@QLutz
Copy link
Author

QLutz commented Sep 17, 2020

The same issue has been raised on Sphinx (sphinx-doc/sphinx#8198). It seems that pinning Pygments did indeed fix the issue for some. I'll go ahead and try to make a remote build doing this.

@stsewd stsewd added the Support Support question label Sep 17, 2020
@QLutz
Copy link
Author

QLutz commented Sep 17, 2020

Pinning Pygments==2.7.1 solved the issue.

Thanks a lot for your time and help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support Support question
Projects
None yet
Development

No branches or pull requests

2 participants