Use canonical URL from html_baseurl #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
use-canonical-url-from-html-baseurl
branch
from
94e40aa to
54f7ead
Compare
stsewd
force-pushed
the
use-canonical-url-from-html-baseurl
branch
from
54f7ead to
5421db8
Compare
|
We should at least be alerting the user, how are they supposed to know that something has changed and their canonical URL is now broken? |
|
I think we are aiming 1.0 here soon? If not, I think we add a warning is |
ericholscher
requested changes
Oct 7, 2020
stsewd
force-pushed
the
use-canonical-url-from-html-baseurl
branch
from
d285196 to
5f17c4a
Compare
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in sphinx itself now https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-html_baseurl,
https://github.com/sphinx-doc/sphinx/blob/e886cc21710e23bc53af83d011131828b1020848/sphinx/themes/basic/layout.html#L135-L137
I was thinking in deprecate this at first, but the change is simple enough to migrate.