Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ API, lack of a space between return type and function name #1065

Closed
rynnwu opened this issue Feb 28, 2021 · 2 comments
Closed

C++ API, lack of a space between return type and function name #1065

rynnwu opened this issue Feb 28, 2021 · 2 comments
Labels
Bug A bug Needed: patch A pull request is required

Comments

@rynnwu
Copy link

rynnwu commented Feb 28, 2021

Problem

Formatting C++ API, it should have a space between return type and function name. Like:

float Sphinx::version
     ^
     |-- A space here

And it was ok in v0.5.1

Reproducible Project

Occurred in the latest version.

Environment Info

  • Python Version: n/a
  • Sphinx Version: n/a
  • RTD Theme Version: latest
@Blendify Blendify added Bug A bug Needed: patch A pull request is required labels Feb 28, 2021
@StrikerRUS
Copy link
Contributor

I can confirm this also happens in our docs.
https://lightgbm.readthedocs.io/en/latest/C-API.html#c.LGBM_BoosterCalcNumPredict

In addition, I'm not sure whether it is the same issue or another bug, but with sphinx_rtd_theme + Breathe there is no space between argument type and its name in C API. But I remember it happened for rtd version < 0.5.0 as well.

image

@stsewd
Copy link
Member

stsewd commented Mar 1, 2021

Thanks for reporting, this is a duplicate of #694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug Needed: patch A pull request is required
Projects
None yet
Development

No branches or pull requests

4 participants