Sphinx 6: Broken Logos and favicons

[Blendify]

Sphinx 6 removes the logo and favicon html template variables.
These have been deprecated since sphinx 4 in favor of logo_url and favicon_url.

This will need to be resolved before the 1.2.0 release.

[benjaoming]

logo_url is fixed in https://github.com/readthedocs/sphinx_rtd_theme/pull/978/files

Edit: No, that's a proposal to have a theme option logo_url that configures the destination for the link reference on the logo 🤦 I'll make a note there that it should be renamed, maybe to logo_href

[benjaoming]

@Blendify did you ever see a deprecation warning about this change in your projects?

I'm wondering because it's reported that people haven't seen the deprecation warnings: sphinx-doc/sphinx#11062

[Blendify]

@Blendify did you ever see a deprecation warning about this change in your projects?

I'm wondering because it's reported that people haven't seen the deprecation warnings: sphinx-doc/sphinx#11062

I have never seen any warnings. I only realized when doing some testing for my projects before we upgraded versions.

[benjaoming]

I agree btw that this is a high-priority for the 1.2.0 roadmap - stuff breaks if we don't fix it. There's no idea in shipping the theme if logos and favicons disappear.. can't make that a known issue :)