-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx 6: Broken Logos and favicons #1404
Comments
Edit: No, that's a proposal to have a theme option |
@Blendify did you ever see a deprecation warning about this change in your projects? I'm wondering because it's reported that people haven't seen the deprecation warnings: sphinx-doc/sphinx#11062 |
I have never seen any warnings. I only realized when doing some testing for my projects before we upgraded versions. |
I agree btw that this is a high-priority for the 1.2.0 roadmap - stuff breaks if we don't fix it. There's no idea in shipping the theme if logos and favicons disappear.. can't make that a known issue :) |
Sphinx 6 removes the
logo
andfavicon
html template variables.These have been deprecated since sphinx 4 in favor of
logo_url
andfavicon_url
.This will need to be resolved before the 1.2.0 release.
The text was updated successfully, but these errors were encountered: