-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing symbols when fast typing in IE (Internet Explorer) #253
Comments
@ai212983, I tried on my windows 8 machine and IE11 and I couldn't reproduce the issue. Can you consistently reproduce the issue and if so, could you post a video of it or something? |
Additionally what version of React are you testing against? |
@ducky427: You have to type really fast. Try to type "test" very fast on https://reagent-project.github.io/ page. Reproducible pretty much every time, if you're typing fast enough. React version is 15.1.0, according to page sources. (yes, i know they've fixed some IE input issues in v.15). I'll record video a bit later, got no proper tools on my Windows notebook. |
@ducky427 Okay, here's mp4 on dropbox. I'm typing "test" first on reagent home page, then on pure react form demo. In reagent demo page you can see a missing character briefly blinking and disappearing. |
@ai212983, you are right. I can also reproduce this issue on |
@ducky427 AFAIK, IE8 is no more officially supported. This video was made with IE11/Win8. Having this bug in IE11 is... well, a bit more troubling than in IE8. Edge works fine though. |
I am sorry. I meant IE11. Fixed my above comment. |
Reproduced also on IE11 on Win7. You don't even have to type fast, just normally |
Seems that IE doesn't report change events like other browsers. I'm looking for a workaround... |
I think I've found a solution: turns out that IE doesn't report change events on every input modification, but just sort of once in a while. That makes the actual value and the value Reagent assumed it had get out of sync, causing lost keystrokes. I've pushed what I hope is a fix to https://reagent-project.github.io and a new snapshot to clojars (i.e 0.6.0-SNAPSHOT). Since the logic for input updates has changed quite a bit, I'd really appreciate if you could try it out. |
@holmsand Works fine to me, greatly appreciated! |
thanks a lot @holmsand. works for me as well! |
Super! Tested this with my component library and this has fixed the problems with IE! Didn't notice any new problems with IE or Chrome. |
This was fixed in 0.6.0 |
Reproduced on IE11, Win8.
https://reagent-project.github.io/ - when fast typing in input field ("The value is now: foo" example), some symbols will be missing. There's no such problem with pure react form. Replacing
:value
with:defaultValue
fixes the problem, so problem is only with controlled inputs.The text was updated successfully, but these errors were encountered: