Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing symbols when fast typing in IE (Internet Explorer) #253

Closed
ai212983 opened this issue Jul 13, 2016 · 14 comments
Closed

Missing symbols when fast typing in IE (Internet Explorer) #253

ai212983 opened this issue Jul 13, 2016 · 14 comments

Comments

@ai212983
Copy link

Reproduced on IE11, Win8.

https://reagent-project.github.io/ - when fast typing in input field ("The value is now: foo" example), some symbols will be missing. There's no such problem with pure react form. Replacing :value with :defaultValue fixes the problem, so problem is only with controlled inputs.

@ducky427
Copy link
Contributor

@ai212983, I tried on my windows 8 machine and IE11 and I couldn't reproduce the issue. Can you consistently reproduce the issue and if so, could you post a video of it or something?

@ducky427
Copy link
Contributor

Additionally what version of React are you testing against?

@ai212983
Copy link
Author

@ducky427: You have to type really fast. Try to type "test" very fast on https://reagent-project.github.io/ page. Reproducible pretty much every time, if you're typing fast enough.

React version is 15.1.0, according to page sources. (yes, i know they've fixed some IE input issues in v.15).

I'll record video a bit later, got no proper tools on my Windows notebook.

@ai212983
Copy link
Author

@ducky427 Okay, here's mp4 on dropbox. I'm typing "test" first on reagent home page, then on pure react form demo. In reagent demo page you can see a missing character briefly blinking and disappearing.

@ducky427
Copy link
Contributor

ducky427 commented Jul 13, 2016

@ai212983, you are right. I can also reproduce this issue on IE8 IE11 on Win8. It works on Chrome 51 on Win8.

@ai212983
Copy link
Author

@ducky427 AFAIK, IE8 is no more officially supported. This video was made with IE11/Win8. Having this bug in IE11 is... well, a bit more troubling than in IE8.

Edge works fine though.

@ducky427
Copy link
Contributor

ducky427 commented Jul 13, 2016

I am sorry. I meant IE11. Fixed my above comment.

@antishok
Copy link

Reproduced also on IE11 on Win7. You don't even have to type fast, just normally

@holmsand
Copy link
Contributor

Seems that IE doesn't report change events like other browsers. I'm looking for a workaround...

@holmsand
Copy link
Contributor

I think I've found a solution: turns out that IE doesn't report change events on every input modification, but just sort of once in a while. That makes the actual value and the value Reagent assumed it had get out of sync, causing lost keystrokes.

I've pushed what I hope is a fix to https://reagent-project.github.io and a new snapshot to clojars (i.e 0.6.0-SNAPSHOT).

Since the logic for input updates has changed quite a bit, I'd really appreciate if you could try it out.

@ai212983
Copy link
Author

@holmsand Works fine to me, greatly appreciated!

@ducky427
Copy link
Contributor

thanks a lot @holmsand. works for me as well!

@Deraen
Copy link
Member

Deraen commented Jul 14, 2016

Super!

Tested this with my component library and this has fixed the problems with IE!

Didn't notice any new problems with IE or Chrome.

@Deraen
Copy link
Member

Deraen commented Mar 11, 2017

This was fixed in 0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants