-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a guide to the docs #302
Comments
@pesterhazy I really like this idea! Would you be interested in starting a PR for this? There are several outstanding issues that I think this could help solve: 249, 209, 166, and 147 I am hopeful that we can triage the relevant links to add to it. And if certain bullets are without links, it could potentially be a good opportunity for community members to write a blog post and help with some documentation. |
Hey @pesterhazy @gadfly361 , This issue is still open, and I'm wondering what else you're hoping to expand the documentation with. Coming from a React background, and not a Clojure background, I found the documentation very different from what I'm used-to. Particularly; I'm used to the React docs which get into patterns like Render-props, Controlled components, etc., and that kind of language seems to be missing from the Reagent docs. Obviously, the patterns in Reagent aren't exactly the same as those in React, but there is overlap, and I think that React developers might find it easier to adopt Reagent, if the docs spoke to them about the kind of patterns that they're already used-to. |
Hi @Xaris as should be obvious by now, I haven't had a chance to work on this. It's obviously quite a lot of work. As you say it would be great to have docs on patterns. But even just basic functions and concepts (like Reactions, or how lifecycle methods translate to Reagent) are barely documented. So if I had the time, I'd probably start there. |
I'd be happy to take a crack at this --although it might take me a couple of weeks as well. Reactions are new to me, but they seem like they might be a similar interface to the new https://stackoverflow.com/questions/40615929/clojure-reagent-how-to-create-reaction-atom |
@Xaris this should help you (although it has a re-frame tilt) https://github.com/Day8/re-frame/blob/master/docs/SubscriptionFlow.md |
Ok, cool --thanks, @mike-thompson-day8 . I probably won't get free to work on this until around New Years, so expect something from me around then. |
Reagent has goods docs but they're somewhat hard to find. Some topics are covered in the API docs, others are discussed in the NEWS posts. Some information again is best covered in re-frame's docs or in the Reagent Cookbook.
To make Reagent more accessible, it would be helpful to include a Table of Contents in the README that links to the various docs. Here's a breakdown of topics that I think would be useful to cover.
Thoughts?
Mounting components
State management
React interop
[:> ...]
Performance
Lifecycle methods
with-let
Accessing DOM nodes/backing instances
Render methods
:render
vs:reagent-render
Reagent-flavored hiccup
[:li.foo>a.bar]
:on-change
->"onChange"
)Handling input elements
Component-local state
Advanced topics
The text was updated successfully, but these errors were encountered: