You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was wondering what do you think about exposing the PortalContext so that we can control where portal should live in the DOM. This might be useful if I want to manage the root level DOM elements.
I'm not sure if hiding PortalContext is something you explicitly wanted and have a reason for. If so, could you share your thoughts?
Thanks Haz! I see, I’m not sure yet about my use case, but I believe some people might be concern about where their portal get created inthe DOM tree. If you have no objection I can send a small PR once I get home.
btw, I love your portal implementation. I’ve been looking around and I think yours is the best one. 👍
🚀 Feature request
Motivation
I was wondering what do you think about exposing the
PortalContext
so that we can control where portal should live in the DOM. This might be useful if I want to manage the root level DOM elements.I'm not sure if hiding PortalContext is something you explicitly wanted and have a reason for. If so, could you share your thoughts?
Example
Using
LayersManager
(https://github.com/giuseppeg/react-layers-manager/blob/master/src/LayersManager.js) as an example:Any portal created inside the
children
will be append as child ofhost
. And nested portal will still function as designed.Possible implementations
Just need to
export PortalContext
?The text was updated successfully, but these errors were encountered: