-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Build fails after release 1.11.2 #560
Comments
I agree that it's very likely a combination of #555, which was mine, and the prefix arg. I can take a look (probably) tonight. |
Another related problem with the change in #555 is that it breaks build using Ninja as Also, unlike I suggest passing |
I'm not able to reproduce the reported issue. What platform are you on? Somewhat related: do you possibly want DESTDIR instead of PREFIX? @denizevrenci that's a good suggestion, thank you |
@lukepalmer I'm using Ubuntu 16.4 LTS, why are you suggesting that I'd use DESTDIR rather than PREFIX and how would that impact the issue? I don't know if it's worth mentioning but I'm using
and of course |
@lukepalmer any updates on this? |
@mo2menelzeiny I've had a similar issue with my own project & 1.11.2. As a workaround you could try to add the following code to the top-level CMakeLists.txt of your project:
|
@lukepalmer do you plan to address this? |
I do. Time has been limited with market conditions but hopefully this week.
If it's causing problems I'd not be in the least offended if people need to
back out the change until I've had time to make sure it's right.
…On Tue, Oct 16, 2018 at 2:33 AM Martin Thompson ***@***.***> wrote:
@lukepalmer <https://github.com/lukepalmer> do you plan to address this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#560 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AExJAZGXSwLvoYlwEMvQkIHwL4UV6fOAks5ulX3JgaJpZM4XMXKf>
.
|
Closing after revert until another approach is proposed. |
I've redone this change as #588. Previously, I also added a travis build matrix to try and catch builds that may be broken for other people. If folks who had trouble previously would like to give it a try before it's merged, that'd be fantastic. Please comment on the PR. |
Migrating from 1.11.1 to 1.11.2 produced a failed build, my guess it's related to the relative path feature merged in #555.
I'm installing the library to
/usr/local/
, does that miss-configure the relative path substitution? https://github.com/real-logic/aeron/blob/44e7e43e820fb34accbc73e7d5b67cd952798a8b/CMakeLists.txt#L59Build script:
Build error log:
The text was updated successfully, but these errors were encountered: