New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C] async DNS res for the C media driver #1566

Merged

vyazelenko merged 34 commits into aeron-io:master from nbradac:async_dns_res_c

Apr 3, 2024

Contributor

nbradac commented Feb 24, 2024

No description provided.


          [C] implement blocking linked queue to be used for sending async even…

27fea88

…ts to the async thread

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_blocking_linked_queue.c Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_blocking_linked_queue.c Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_blocking_linked_queue.c Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_blocking_linked_queue.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_blocking_linked_queue.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_blocking_linked_queue.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_blocking_linked_queue.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_blocking_linked_queue.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_spsc_concurrent_linked_queue.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_spsc_concurrent_linked_queue.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_spsc_concurrent_linked_queue.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_spsc_concurrent_linked_queue.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_spsc_concurrent_linked_queue.h Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_spsc_concurrent_linked_queue.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_thread.h Show resolved Hide resolved

nbradac added 3 commits

February 25, 2024 16:54


          [C] add aeron_driver_executor

a90e12b


          [C] add some err messages

1a0a994


          [C] simplify linked queue, move executor to client

5c55dcf

github-advanced-security bot found potential problems

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_executor.c Fixed Show resolved Hide resolved

aeron-client/src/main/c/concurrent/aeron_executor.c Fixed Show fixed Hide fixed

nbradac and others added 10 commits

February 27, 2024 13:22


          [C] fix SET_ERR usage

cdcddd2


          Merge branch 'master' into async_dns_res_c

e7fd278


          [C] add executor to driver conductor, fix unit test

b8b4e30


          [C] add offer_ex to re-use queue nodes, add return_queue to executor

cc87e2b


          Merge branch 'master' into async_dns_res_c

0846f3d


          [C] split aeron_udp_channel_parse, use executor for aeron_driver_cond…

284d1c6

…uctor_on_add_network_publication, error handling is a work in progress


          [C] add error handling - unit tests are passing

b48a862


          [C] switch windows to use critical sections instead of mutexes, imple…

17bc837

…ment condition variables


          [C] refactor executor logic out of udp_channel and into driver_conductor

59658e6


          Merge branch 'master' into async_dns_res_c

c897975

nbradac added 11 commits

March 7, 2024 08:50


          [C] set async cmd in flight BEFORE submitting to the executor

f6a77d8


          [C] fill out params in aeron_driver_conductor_on_add_spy_subscription…

096ed48

…_complete


          [C] async DNS for add/remove_send_destination

1f79a2d


          [C] endpoint and control re-resolution

ac0464f


          [C] refactor async commands

72238b5


          Merge branch 'master' into async_dns_res_c

807e06f


          [C] add config option

f49478e


          [C] async executor based solely on config option, threads = 0 for dri…

e86aceb

…ver conductor tests


          Merge branch 'master' into async_dns_res_c

5f83550


          [C] skip out of client command processing loop if the last command pu…

b06258a

…t an async event in flight


          Merge branch 'master' into async_dns_res_c

28462e4

vyazelenko marked this pull request as draft

March 13, 2024 13:03

nbradac added 2 commits

March 18, 2024 08:39


          Merge branch 'master' into async_dns_res_c

062fad8


          Merge branch 'master' into async_dns_res_c

9c14e62

Contributor

vyazelenko commented Mar 18, 2024

@nbradac You need to pull from master again.


          Merge branch 'master' into async_dns_res_c

3255d3d

vyazelenko marked this pull request as ready for review

March 18, 2024 16:00

nbradac added 2 commits

April 1, 2024 09:57


          [C] merge master

94e656b


          Merge branch 'master' into async_dns_res_c

bcf7229

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/concurrent/aeron_executor.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-driver/src/main/c/aeron_driver_conductor.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-driver/src/main/c/aeron_driver_conductor.c

+                      }
+                      else
+                      {
+                          // TODO set current errcode/errmsg to what was handed to this function???

Contributor

mikeb01 Apr 1, 2024

I think we do have to set those if we are going to use them below as they are thread local variables. Can we put together a system test that will trigger this code path to see what would happen?

Contributor Author

nbradac Apr 2, 2024

Right now, the only time the async_client_command->on_error is used we don't check to see what the error was. The original code just set ss_family = AF_UNSPEC and proceeded as normal. The new code sets the on_error callback so that we have an opportunity to set AF_UNSPEC, but it then just calls the _complete() callback directly. So I'm not sure we've got a good way to test this out at the moment - i.e. even if I set the errcode and errmsg thread local variables here, nobody ever reads them, so it won't matter.

mikeb01 reviewed

View reviewed changes

aeron-driver/src/main/c/aeron_driver_conductor.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/main/c/collections/aeron_linked_queue.c Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/test/c/concurrent/aeron_executor_test.cpp Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-client/src/test/c/concurrent/aeron_executor_test.cpp Outdated Show resolved Hide resolved

nbradac added 3 commits

April 2, 2024 12:39


          [C] a few fixes based on review comments

31d1f31


          [C] add aeron_thread_attr_t

b5fdc9c


          Merge branch 'master' into async_dns_res_c

fa937d2

vyazelenko merged commit 4ed1e1b into aeron-io:master

32 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet