Cmake improvements #507
Merged
Cmake improvements #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See google/benchmark#594. The quick fix is to disable assembly tests so that the failing part does not get included in the cmake configure step.
It is possible to add a subproject using add_subdirectory command of CMake. In that particular case, CMAKE_(SOURCE|BINARY)_DIR points to the top level project's directories while CMAKE_CURRENT_(SOURCE|BINARY)_DIR points to Aeron's directories. Stand alone builds or adding Aeron as a subproject using ExternalProject_Add does not get affected.
This makes all thirdparty related build artifacts go under the current binary directory set by cmake with project name based hierarchy.
Unlike GNU make, ninja (https://ninja-build.org/) needs to know which target produces the named output. Without marking the output libraries as byproducts ninja does not know that it is a file that will be created later on by one of the targets and assumes it missing.
This allows transitivity of the include directories for the libraries defined by this project.
|
Very nice! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.