[C++] Fix narrowing conversion in client #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSCV is correctly complaining about the narrowing conversion from `std::size_t` to `int` in `AtomicArrayUpdater::removeElement`. This patch makes us return a `std::size_t` instead. Using `-1` to signify an invalid length is not needed as the length value is not used anyway if the pointer is null. Hence we use `0` as the invalid value and avoid the narrowing conversion.
|
I restarted the failed build. Once it comes back OK, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSCV is correctly complaining about the narrowing conversion from
std::size_ttointinAtomicArrayUpdater::removeElement.This patch makes us return a
std::size_tinstead. Using-1tosignify an invalid length is not needed as the length value is not used
anyway if the pointer is null. Hence we use
0as the invalid value andavoid the narrowing conversion.