Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granting Capabilities automatically adds Default Menu Items even if the Menu has already been customized #175

Open
d4mation opened this issue Nov 1, 2018 · 1 comment
Labels

Comments

@d4mation
Copy link
Member

d4mation commented Nov 1, 2018

This is super edge case, but if you were to for instance grant list_users and create_users to an unprivileged Role such as Subscriber when their Menu has already been Customized, it will automatically add the Users Menu Item without the need to go in and manually add it in.

I don't think this is exactly a problem, but in the case of Plugins/Themes adding Menu Items those do require you to add them in manually.

Suppose I'll mark wontfix and just have this logged here for informational purposes.

Edit: This was an example. Please don't give Subscribers the ability to make Admins, guys.

@d4mation
Copy link
Member Author

d4mation commented Oct 11, 2021

The bit where it seems this would grant Subscribers the ability to create Admins seems to no longer be accurate (in this scenario, the "Role" selection field no longer is shown) but the rest of this is still valid information.

Edit: Well, provided they don't also have promote_users granted to their Role. Which, again, please don't give Subscribers the ability to make Admins, guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant