You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I use Swiftlint for one very big project for only changed files by specyifing --use-script-input-files --force-exclude and after some checks and measurements with Time Profiler I found out that excluding paths takes more then 3-4 seconds on my machine.
I investigated that problem and found next: while excluding it finds ALL lintable files in all excluded paths from config. And then the result set of excluded swift files is subtracted from the input paths set.
I find it quiet strange algorithm, because why do we need to collect all lintable files for example in excluded Pods directory.
So, I tryed to changed it to the next exclusion algorithm:
If you can improve the algorithm I'm all for it, although it seems like your latest attempt in #3345 is actually changing the behavior, not sure if you're expecting that to happen or not.
This issue has been automatically marked as stale because it has not had any recent activity. Please comment to prevent this issue from being closed. Thank you for your contributions!
stalebot
added
the
wontfix
Issues that became stale and were auto-closed by a bot.
label
Jan 6, 2021
I use Swiftlint for one very big project for only changed files by specyifing
--use-script-input-files --force-exclude
and after some checks and measurements with Time Profiler I found out that excluding paths takes more then 3-4 seconds on my machine.I investigated that problem and found next: while excluding it finds ALL lintable files in all excluded paths from config. And then the result set of excluded swift files is subtracted from the input paths set.
I find it quiet strange algorithm, because why do we need to collect all lintable files for example in excluded Pods directory.
So, I tryed to changed it to the next exclusion algorithm:
And it still excludes files, lints and works for those 3-4 seconds faster
Are there any special reasons for current exclusion algorithm? or it can be changed to something like I used?
The text was updated successfully, but these errors were encountered: