Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule Request: Weak delegate rule should allow @UIApplicationDelegateAdaptor #3456

Closed
2 tasks done
jrturton opened this issue Dec 4, 2020 · 0 comments
Closed
2 tasks done

Rule Request: Weak delegate rule should allow @UIApplicationDelegateAdaptor #3456

jrturton opened this issue Dec 4, 2020 · 0 comments

Comments

@jrturton
Copy link
Contributor

jrturton commented Dec 4, 2020 •
edited
Loading

New Issue Checklist

New rule request

The weak delegate rule fires on the following declaration, which is not appropriate:

@UIApplicationDelegateAdaptor(AppDelegate.self) var appDelegate

I have begun making the changes to implement this but I want to check that I'm not missing something - there doesn't seem to be a way of detecting a property wrapper specifically from the SourceKittenDictionary, and I have to do it by reading the attributes out using the offsets?

If this is a question better asked as part of a PR submission then that's #3457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpsim @jrturton