Throwing unnecessary empty_count

[lalkrishna]

New Issue Checklist

• Updated SwiftLint to the latest version
• I searched for existing GitHub issues

Describe the bug

I'm getting Empty Count Violation:

Prefer checking isEmpty over comparing count to zero. (empty_count)

for the below code.

guard let count = notify.object as? Int else { fatalError() }
if count == 0 {
}

Complete output when running SwiftLint, including the stack trace and command used

$ swiftlint lint

Environment

#  SwiftLint Rules Configuration
#  https://github.com/realm/SwiftLint
#
# By default, SwiftLint uses a set of sensible default rules you can adjust:
disabled_rules: # rule identifiers turned on by default to exclude from running
#  - colon
#  - comma
#  - control_statement
  - trailing_whitespace
  - unused_optional_binding
  - multiple_closures_with_trailing_closure
  - unused_capture_list
  
opt_in_rules: # some rules are turned off by default, so you need to opt-in
  - empty_count # Find all the available rules by running: `swiftlint rules`

line_length: 200
function_body_length: 60

#type_body_length:
#  - 300 # warning
#  - 400 # error
## or they can set both explicitly
#file_length:
#  warning: 500
#  error: 1200

nesting:
   type_level: 3
identifier_name:
#  min_length: # only min_length
#    error: 4 # only error
  excluded: # excluded via string array
    - id
    - URL
    - GlobalAPIKey
    - km
cyclomatic_complexity:
  ignores_case_statements: true
type_name:
  min_length: 3 # only warning
  max_length: # warning and error
    warning: 50
    error: 60

[davidpasztor]

Unfortunately this seems like an intentional decision as described in this comment on #827

[jpsim]

@davidpasztor is exactly right. There's only so much information SwiftLint has at the pre-typechecked stage. Consider writing an analyzer rule similar to #3914 if you'd like a more accurate, typechecked version of the empty_count rule.