Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Buildkite config to repo #3637

Closed
2 tasks done
sethfri opened this issue May 20, 2021 · 1 comment
Closed
2 tasks done

Add Buildkite config to repo #3637

sethfri opened this issue May 20, 2021 · 1 comment

Comments

@sethfri
Copy link
Contributor

sethfri commented May 20, 2021

New Issue Checklist

Describe the bug

It was difficult to troubleshoot why Buildkite wasn't working in #3583 because I couldn't find the relevant configuration. I looked in the Dangerfile and azure-pipelines.yml, but I still couldn't figure out how the Buildkite check was getting triggered. It turns out it's because the CI job was removed from Azure Pipelines in #2941.

It would be great to check in the Buildkite configuration to make it easy for contributors to inspect how the code in their PRs is getting run, and even allow for PRs on the configuration itself so that contributors might make improvements.

Thanks, as always, for all you do @jpsim!

@SimplyDanny
Copy link
Collaborator

Done in #3893.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants