redundant_optional_initialization removes opening bracket before property observer

[maikasshoff]

New Issue Checklist

• Updated SwiftLint to the latest version
• I searched for existing GitHub issues

Describe the bug

The redundant_optional_initialization rule removes the opening bracket before a property observer which causes a syntax issue. For example

var foo: String? = nil {
  didSet {
    print("foo")
  }
}

is changed to

var foo: String?
  didSet {
    print("foo")
  }
}

Complete output when running SwiftLint, including the stack trace and command used

$ swiftlint lint       

Linting Swift files in current working directory
Linting 'Foo.swift' (1/1)
/Foo.swift:3:21: warning: Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant. (redundant_optional_initialization)
Done linting! Found 1 violation, 0 serious in 1 file.

Environment

$ swiftlint version
swiftlint version
0.44.0

@iressler

[iressler]

Interesting, I assume you are actually running swiftlint lint --fix (or equivalent)?

I'll take a look at this when I get a chance, however I'm not familiar with how the autocorrect works. This may be a quick fix for someone familiar with it so if someone else wants to take a stab at it please do.

[naru-jpn]

Hi, I found same problem and created PR to fix this issue :) #3717

[morluna]

This is breaking our workflow since our development team uses the Homebrew installation of swiftlint for analysis 😔 Our workaround is to disable the rule for now, but a fix would be appreciated. Thanks @naru-jpn for the fix.

[BrunoVillanova-SaudeID]

Awaiting PR merge and release.

[maartenbusstra]

We ran into this issue as well. For good measure, we're turning off automatically fixing issues in CI, as the underlying project shouldn't change when publishing builds.

[ansonj]

In case anyone is watching this issue for updates, the 0.45.0 release includes the fix for this issue. Tested it, and looks good for me:
https://github.com/realm/SwiftLint/releases/tag/0.45.0