Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup computed accessors order rule #3727

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

PaulTaykalo
Copy link
Collaborator

Speedup computer accessor rules by specifying range where subdictionaries should be searched for. This should significantly reduce times needed to find keywords

@PaulTaykalo PaulTaykalo added the hacktoberfest-accepted Pull requests accepted as valid Hacktoberfest contributions. label Sep 30, 2021
@SwiftLintBot
Copy link

SwiftLintBot commented Sep 30, 2021

12 Messages
📖 Linting Aerial with this PR took 0.23s vs 0.23s on master (0% slower)
📖 Linting Alamofire with this PR took 0.28s vs 0.27s on master (3% slower)
📖 Linting Firefox with this PR took 1.18s vs 1.19s on master (0% faster)
📖 Linting Kickstarter with this PR took 1.81s vs 4.68s on master (61% faster)
📖 Linting Moya with this PR took 0.14s vs 0.14s on master (0% slower)
📖 Linting Nimble with this PR took 0.14s vs 0.14s on master (0% slower)
📖 Linting Quick with this PR took 0.08s vs 0.07s on master (14% slower)
📖 Linting Realm with this PR took 0.58s vs 0.58s on master (0% slower)
📖 Linting SourceKitten with this PR took 0.12s vs 0.12s on master (0% slower)
📖 Linting Sourcery with this PR took 0.4s vs 0.39s on master (2% slower)
📖 Linting Swift with this PR took 1.24s vs 1.24s on master (0% slower)
📖 Linting WordPress with this PR took 2.04s vs 2.04s on master (0% slower)

Generated by 🚫 Danger

@PaulTaykalo PaulTaykalo force-pushed the fix/speedup-computed-accessors-order-rule branch from 12e735d to acd8bb3 Compare September 30, 2021 23:41
@PaulTaykalo PaulTaykalo merged commit 6b8c444 into master Oct 1, 2021
@PaulTaykalo PaulTaykalo deleted the fix/speedup-computed-accessors-order-rule branch October 1, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Pull requests accepted as valid Hacktoberfest contributions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants