Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused_capture_list rule in favor of the Swift compiler warning #4656

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Deprecate unused_capture_list rule in favor of the Swift compiler warning #4656

merged 2 commits into from
Dec 22, 2022

Conversation

Cyberbeni
Copy link
Contributor

@Cyberbeni Cyberbeni commented Dec 22, 2022

similarly to #4618

Tested all the triggering examples with Xcode 14.0.1

@SwiftLintBot
Copy link

SwiftLintBot commented Dec 22, 2022

18 Messages
📖 Linting Aerial with this PR took 0.15s vs 0.13s on main (15% slower)
📖 Linting Alamofire with this PR took 0.09s vs 0.09s on main (0% slower)
📖 Linting Brave with this PR took 0.41s vs 0.41s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 0.25s vs 0.23s on main (8% slower)
📖 Linting Firefox with this PR took 0.38s vs 0.38s on main (0% slower)
📖 Linting Kickstarter with this PR took 0.48s vs 0.49s on main (2% faster)
📖 Linting Moya with this PR took 0.11s vs 0.11s on main (0% slower)
📖 Linting NetNewsWire with this PR took 0.18s vs 0.19s on main (5% faster)
📖 Linting Nimble with this PR took 0.08s vs 0.08s on main (0% slower)
📖 Linting PocketCasts with this PR took 0.38s vs 0.38s on main (0% slower)
📖 Linting Quick with this PR took 0.06s vs 0.06s on main (0% slower)
📖 Linting Realm with this PR took 0.43s vs 0.41s on main (4% slower)
📖 Linting SourceKitten with this PR took 0.07s vs 0.07s on main (0% slower)
📖 Linting Sourcery with this PR took 0.2s vs 0.18s on main (11% slower)
📖 Linting Swift with this PR took 0.92s vs 0.91s on main (1% slower)
📖 Linting VLC with this PR took 0.11s vs 0.12s on main (8% faster)
📖 Linting Wire with this PR took 0.45s vs 0.45s on main (0% slower)
📖 Linting WordPress with this PR took 0.59s vs 0.62s on main (4% faster)

Generated by 🚫 Danger

Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jpsim jpsim enabled auto-merge (squash) December 22, 2022 15:22
@jpsim jpsim merged commit d76daf5 into realm:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants