Fix void_return rule to support async and async throws functions #4772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4766. I’ve noticed there is also #4158 which rewrites the whole rule to use
SwiftSyntax
, which would be also sufficient to fix the issue. But this PR adds additional test cases for theasync
andasync throws
functions, so I think we can use this fix for now and consider #4158 as a long-term solution, which should hopefully also pass the new tests.Fixes: #4766
Refs: #4158