-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check string before command for invalid_swiftlint_command
rule
#5204
Merged
SimplyDanny
merged 10 commits into
realm:main
from
mildm8nnered:mildm8nnered-check-string-before-command
Sep 5, 2023
Merged
check string before command for invalid_swiftlint_command
rule
#5204
SimplyDanny
merged 10 commits into
realm:main
from
mildm8nnered:mildm8nnered-check-string-before-command
Sep 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
…d by non-whitespace or comment characters
mildm8nnered
force-pushed
the
mildm8nnered-check-string-before-command
branch
from
September 4, 2023 22:58
ebebddb
to
e3cbad4
Compare
mildm8nnered
changed the title
Mildm8nnered check string before command
check string before command for Sep 4, 2023
invalid_swiftlint_command
rule
SimplyDanny
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements!
Closed
2 tasks
KS1019
pushed a commit
to KS1019/SwiftLint
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor improvements to the
invalid_swiftlint_command
rule.Location is now more accurate - we point to the start of the
swiftlint
command.Separate reasons are now provided for invalid actions, modifier, or missing rules.
We now check whether
swiftlint
is preceded by whitespace or a comment/
character, sosswiftlint:disable some_rule
for example, would now generate a warning.