Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiftlint and SwiftLintFramework being build when only using SwiftLintPlugin on MacOS #5372

Closed
2 tasks done
geertbleyen opened this issue Dec 4, 2023 · 1 comment · Fixed by #5404
Closed
2 tasks done
Labels
help Questions or user problems that require more explanation rather than code changes. integration Issues related to integration of SwiftLint into toolchains.

Comments

@geertbleyen
Copy link

New Issue Checklist

Describe the bug

I've noticed that while we are only using and referring SwiftLintPlugin form the SwiftLint SPM products, Xcode is building the SwiftLint and SwiftLintFramework targets regardless. These targets take quite some time to build, and don't add anything to the result as they are not used anywhere, and the plugin uses the binaryTarget dependency on MacOS.
Tbh, I suspect this to be an Xcode/Apple related issue, but wanted to report it nonetheless to verify the finding.
Are we doing something wrong, or this is just how it currently works in Xcode

Environment

  • SwiftLint version: 0.54.0
  • Xcode version: 15.0.1
  • Installation method: SPM integration
image image image Don't mind the 0.51.0 version specced here, as our package.resolved has 0.54.0 locked in. image
  • Paste your configuration file: NA
@SimplyDanny SimplyDanny added help Questions or user problems that require more explanation rather than code changes. integration Issues related to integration of SwiftLint into toolchains. labels Dec 5, 2023
@julien-baillon
Copy link
Contributor

julien-baillon commented Dec 26, 2023

Hi @geertbleyen , I'm facing the same issue. I have created this PR to fix this issue. Could you test it by using .package(url: "https://github.com/julien-baillon/SwiftLint", branch: "jb-plugin-dependencies"), in you Package.swift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help Questions or user problems that require more explanation rather than code changes. integration Issues related to integration of SwiftLint into toolchains.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants