Adds baseline and write_baseline config file options
#5552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
mildm8nnered
force-pushed
the
mildm8nnered-baseline-config2
branch
from
1342498
to
01cc6fd
Compare
SimplyDanny
reviewed
May 4, 2024
So I don't expect it to get that much use, but I could see a few possible use cases. If you want to generate the Baselines in your CI environment, and can't pass command line options, then this would let you do so without having to reconstruct that environment locally. I could imagine people having a monthly or even yearly job for this. If you wanted to track whether existing violations were getting fixed, you could write out a baseline for the build, and then use |
mildm8nnered
force-pushed
the
mildm8nnered-baseline-config2
branch
2 times, most recently
from
1217db3
to
f97a825
Compare
mildm8nnered
force-pushed
the
mildm8nnered-baseline-config2
branch
from
f97a825
to
e3830ca
Compare
SimplyDanny
approved these changes
Jun 25, 2024
CHANGELOG.md
Outdated
| * Adds `baseline` and `write_baseline` configuration file settings, equivalent | ||
| to the `--baseline` and `--write-baseline` command line options. | ||
| [Martin Redington](https://github.com/mildm8nnered) | ||
| [#5552](https://github.com/realm/SwiftLint/issues/5552) |
There was a problem hiding this comment.
This needs to be moved up into the "Main" section.
… can be used by people who can't pass command line arguments (e.g. plugin users).
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
mildm8nnered
force-pushed
the
mildm8nnered-baseline-config2
branch
from
2c9e59d
to
a90e3c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So baselines can be used by people who can't pass command line arguments (e.g. plugin users).
baselineandwrite_baseline- these behave exactly the same way as their command line equivalents. The command line will take preference if there is a conflict, but there is not way to "unset" the config file entries from the command line - if there is abaselineconfig file entry, you can override it to be a different value, but there is no way to tell SwiftLint "don't read a baseline at all".This is very similar to the PR from a while ago adding a
strictconfig option - #5226