Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"View on GitHub" header link shouldn't be generated when no GitHub URL is specified #244

Closed
khoogheem opened this issue May 30, 2015 · 2 comments
Closed

"View on GitHub" header link shouldn't be generated when no GitHub URL is specified #244

khoogheem opened this issue May 30, 2015 · 2 comments
Assignees
@jpsim
Labels
bug difficulty-easy priority-high ruby
Milestone
Before

Comments

@khoogheem
Copy link

I recommend that the Link to GitHub is removed unless you specify the -g option.

OR Better yet.. I would like to actually see a option that we could specify any Project URL so if you host on GitHub or BitBucket, or want to point it back to your Company URL project page..
@jpsim
Copy link
Collaborator

jpsim commented May 30, 2015

You're right that the "View on GitHub" link in the upper right of the page still gets generated regardless of if a GitHub url is specified. We'll be sure to fix that.

@jpsim jpsim changed the title GitHub Link- Suggestion "View on GitHub" header link shouldn't be generated when no GitHub URL is specified May 30, 2015
@mbogh mbogh mentioned this issue Sep 7, 2015
Merged
@jpsim
Copy link
Collaborator

jpsim commented Sep 7, 2015

Fixed in #292.

@jpsim jpsim closed this as completed Sep 7, 2015
@pigeon-archive pigeon-archive modified the milestone: The Past Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpsim jpsim

Labels
bug difficulty-easy priority-high ruby
Projects
None yet
Milestone
Before
Development

No branches or pull requests
3 participants
@jpsim @khoogheem @pigeon-archive