Fixed wildcards in file exclude config #640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
exclude
config option is clearly intended to support wildcards, but they weren’t working because:fnmatch?
passed the arguments in the wrong order andThis PR makes wildcard excludes work as expected. The corresponding specs update adds a regression test for wildcards.
The specs were not passing when I checked them out. I just regenerated them to match what jazzy was producing without further investigation. Here’s what changed.