Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Table.h: Mixed(ColumnType v) #13

Closed
bmunkholm opened this issue Mar 8, 2012 · 1 comment
Closed

Bug in Table.h: Mixed(ColumnType v) #13

bmunkholm opened this issue Mar 8, 2012 · 1 comment

Comments

@bmunkholm
Copy link
Contributor

In Table.h:
class Mixed {
public:
explicit Mixed(ColumnType v) {assert(v = COLUMN_TYPE_TABLE); m_type = COLUMN_TYPE_TABLE;}

is missing a "=" after "v =" to assert correctly.

Better yet would be to prevent this run-time error at compile time with something like:
class ColumnTypeTable {};
class Mixed {
public:
Mixed(ColumnTypeTable) { ... }
}
Use:
Mixed m(ColumnTypeTable());

@ghost ghost assigned astigsen Mar 8, 2012
@ghost ghost assigned kspangsege Apr 24, 2012
@astigsen
Copy link
Contributor

Verified that this is fixed today

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants