Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Set methods #4225

Closed
7 of 10 tasks
sync-by-unito bot opened this issue Dec 16, 2020 · 4 comments
Closed
7 of 10 tasks

Add more Set methods #4225

sync-by-unito bot opened this issue Dec 16, 2020 · 4 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Dec 16, 2020

Set specific methods that are needed to satisfy the SDK contracts:

  • assign_difference
  • assign_intersection
  • assign_symmetric_difference
  • assign_union
  • is_strict_subset
  • is_subset
  • is_strict_superset
  • is_superset
  • intersects
  • set_equals - this should return whether the two collections contain the same unique elements
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 4, 2021

➤ Yavor Georgiev commented:

[~simon.ulsnes] what's your take, can these be implemented?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 28, 2021

➤ Simon Ulsnes commented:

Yes, those are very easy to implement. Strict sub-/superset can be implemented as just checking up front whether the size is the same, and if it is, return false.

Set-equals is also trivial.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 28, 2021

➤ Nikola Irinchev commented:

This is the case if the argument is also a set - for lists and results, which may contain duplicates, the size check is not sufficient to determine whether one is a strict sub/superset of the other.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Feb 18, 2021

➤ Simon Ulsnes commented:

#4435

@sync-by-unito sync-by-unito bot closed this as completed Feb 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants