Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linked circular edge inside a sketch not used in pad #49

Open
wsteffe opened this issue Sep 2, 2018 · 5 comments
Open

linked circular edge inside a sketch not used in pad #49

wsteffe opened this issue Sep 2, 2018 · 5 comments
Labels

Comments

@wsteffe
Copy link

wsteffe commented Sep 2, 2018

I have reproduced the problem in the model uploaded into "Freecad Forum/Assembly/Assembly3 Preview". The model contains 2 sketches and 2 pads.

Each sketch inludes a rectangle and an inner circle.

In the first sketch the circle is created with circle feature of sketch.
In the second sketch the circle is created as a link to external geometry (the hole created by padding the first sketch).

Both sketches are paded but the result is different:
-The first sketch produces a brick with a hole (as expected)
-The second sketch produces only a brick without the hole.

screenshot from 2018-09-02 13-41-08
screenshot from 2018-09-02 13-39-51
screenshot from 2018-09-02 13-39-06

@ceremcem
Copy link
Collaborator

ceremcem commented Sep 2, 2018

(Continuing from FreeCAD forum)

quote from wsteffe:
Actually I do not understand your image because the cylinder with diameter=10 mm is a pad (not a
hole) like the rectangular box.
Why in your image there is a discontinuity between that cylinder and the box ? They should be fused.

It's maybe because I actually created that image with Gimp, with my advanced copy/paste skills :P

As it is already answered in the forum, there is no circle in Sketch001 thus in Pad001.

If you want to explode it without using Asm3 features (if you don't want something dynamic) you should perform a pocket operation. This is the result:

image

This is the file: aaa.fcstd.remove-extension.zip

If you want something dynamic, you should see Modeling Using Assembly tutorial.

@realthunder
Copy link
Owner

In the first sketch the circle is created with circle feature of sketch.
In the second sketch the circle is created as a link to external geometry (the hole created by padding the first sketch).

In current FC, external geometry can only be used to constrain other geometry you created. In your specific case, you have to manually create a circle constrained to external circle's origin and radius.

There is pull request in upstream to let use the external geometry for modeling, it is not merged yet.

@wsteffe
Copy link
Author

wsteffe commented Sep 3, 2018

Thanks realthunder,
I think you are referring to the pull request named "Sketcher: External Geometry as defining" of abdullahtahiriyo. I have lloked into the realted forum thread but it seems that this work was halted due to problems related with the proposed extension of ExternalProperty Class.
I hope that a viable solution will be found soon.

@luzpaz
Copy link
Collaborator

luzpaz commented Mar 3, 2021

There is pull request in upstream to let use the external geometry for modeling, it is not merged yet.

@realthunder which one?

@realthunder
Copy link
Owner

I think there was a PR for that almost three years ago, before I worked on topo naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants