Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the infer-timestamp direction, at least temporarily #169

Closed
NathanReb opened this issue Sep 11, 2019 · 1 comment
Closed

Remove the infer-timestamp direction, at least temporarily #169

NathanReb opened this issue Sep 11, 2019 · 1 comment

Comments

@NathanReb
Copy link
Contributor

NathanReb commented Sep 11, 2019

The --direction=infer-timestamp is not working very well. In particular it can't be used in dune because dune copies all the files to the _build directory first and therefore messes with the timestamps.

While I like the idea of having such an option, I'm quite struggling to find a good workflow for it outside of dune and its promotion mechanism.

I'd suggest we simply remove it for now until we have that figured out.

Note that if anyone's actually using this option and has a good workflow to integrate it outside of dune I'd love to hear about it. If that were the case an alternative would be to remove it from ocaml-mdx rule at least so that it only produces options that actually work fine with dune.

@NathanReb
Copy link
Contributor Author

This has been fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant