Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more configuration of the test command #193

Closed
NathanReb opened this issue Nov 13, 2019 · 2 comments · Fixed by #194
Closed

Allow more configuration of the test command #193

NathanReb opened this issue Nov 13, 2019 · 2 comments · Fixed by #194

Comments

@NathanReb
Copy link
Contributor

Currently the ocaml-mdx test command isn't very flexible with regard to its output.

It always writes it to the input file with a .corrected. While this is a good default, I think it'd be good to:

  1. Document it in the test command man page.
  2. Add a --to-stdout/-O option to write to stdout instead
  3. Add a --output <file>/-o <file> option to write to a different file

These would all be backward compatible changes with the current behaviour.

While I believe we should, in the future, try to promote the dune workflow over the ocaml-mdx test one, I think until we have a proper integration these additions would make more usable to everyone, including ourselves since I actually met that limitation while working on the test!

What do you think? @samoht @Julow

@samoht
Copy link
Collaborator

samoht commented Nov 13, 2019

sounds like a good idea. Maybe just use -o - to write on stdout instead of adding an other option -O.

@NathanReb
Copy link
Contributor Author

Sure! Whatever feels more standard/natural!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants