-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: workflow continue #202
Comments
As discussed live, we will opt for the first approach using a single workflow run with a single workspace. This will lead to the creation of a new $ reana-client run
$ # Workflow fails
$ reana-client status
NAME RUN_NUMBER CREATED STATUS PROGRESS
workflow 4 2018-11-21T08:03:02 failed 1/1
$ # user modifies the spec or files
$ reana-client status
NAME RUN_NUMBER CREATED STATUS PROGRESS
workflow 4 2018-11-21T08:03:02 dirty 1/1
$ reana-client continue |
Note that incremental development is possible via CWL new "target" option. We are going to add this option to Serial and Yadage as part of |
The aims behind this issue can be achieved by allowing users to rerun the same workflow on the same workspace. (Useful for debugging code until it is ready without having to upload files etc.) |
Use case scenario
A user submits a serial workflow consisting of say seven steps, and the workflow execution run number ten fails at "step four" with an exception due to an error in the analysis code. The user spots a problem in the big
myfilter.py
code touching the execution of step four, inspects the temporary results to make sure that previous steps are not affected, resubmits the corrected version of themyfilter.py
code, and would like to resume the execution from the last good known state, i.e. from "step three".Notes
Note that we cannot use job cache to run previous steps, because the same big file
myfilter.py
is use for previous steps.Implementation
We should decited whether we shall:
reuse the same run number 10 and simply continue as if nothing happened; this is alike to what users would typically do locally when developing workflows;
create a new run number 11 using new workspace directory and hard-copy or symlink files from run number 10's workspace to seed it;
create a new run number 11 using the same workspace directory as run number 10; this would necessitate to create a DB table
run-number <--> workdir
;Note that the latter functionality may come handy later for sharing workspace directories amongst several people.
CLI
A fictive usage scenario:
Note that the
continue
command may be calledresume
orrestart
or perhaps even an option to the already-existingstart
command.The text was updated successfully, but these errors were encountered: