Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube: not running on latest version raises error #323

Open
dprelipcean opened this issue Sep 18, 2019 · 3 comments
Open

minikube: not running on latest version raises error #323

dprelipcean opened this issue Sep 18, 2019 · 3 comments

Comments

@dprelipcean
Copy link
Contributor

As I'm not running the latest minikube version, I get the notification that there's a new version. However, when I try to set my environment variables, it actually fails. Funnily enough, when I run it a second time it goes through successfully.

$ eval $(reana-dev setup-environment)
⚠️  minikube 1.3.1 is available! Download it: https://github.com/kubernetes/minikube/releases/tag/v/1.3.1
bash: export: `notice,': not a valid identifier
bash: export: `run:': not a valid identifier
bash: export: `minikube config set WantUpdateNotification false192.168.39.236:30443': not a valid identifier
$ eval $(reana-dev setup-environment)

Not sure whether we could do something about it more than suggest to use latest versions.

@tiborsimko
Copy link
Member

Is it only due to the notification message? What is the full output of:

$ reana-dev setup-environment

i.e. without eval?

Note also that you can switch off the upgrade warning by doing:

$ minikube config set WantUpdateNotification false

You may want to run it on your machine to silence these warnings and retry the command.

@diegodelemos
Copy link
Member

This fails because we do not do any check on the output of minikube ip in REANA-Cluster CLI, we always trust it will give an IP, which breaks setting the REANA_SERVER_URL environment variable when the output is something else (for example update warnings).

@tiborsimko
Copy link
Member

Yeah, we could check minikube ip output to be ready for more situations, however setting WantUpdateNotification to false should also solve this. Since Minikube deployments are only used by developers, it should be sufficient, as people can run update-check manually...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants