Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(commitlint): check for the presence of concrete PR number #698

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

tiborsimko
Copy link
Member

  • ci(commitlint): check for the presence of concrete PR number

    Enrich commitlint checker in order to check the precise PR number in the
    commit log headline.

  • ci(shellcheck): fix exit code propagation

    Return properly the exit code status of shellcheck command when looping
    through shell script files.

Return properly the exit code status of shellcheck command when looping
through shell script files.
…b#698)

Enrich commitlint checker in order to check the precise PR number in the
commit log headline.
@tiborsimko tiborsimko force-pushed the ci-commitlint-shellcheck branch from 361b934 to fa5b7c7 Compare January 25, 2024 11:36
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b278f1) 58.57% compared to head (fa5b7c7) 58.57%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #698   +/-   ##
=======================================
  Coverage   58.57%   58.57%           
=======================================
  Files          24       24           
  Lines        2390     2390           
=======================================
  Hits         1400     1400           
  Misses        990      990           

@tiborsimko tiborsimko merged commit fa5b7c7 into reanahub:master Jan 26, 2024
26 checks passed
@tiborsimko tiborsimko deleted the ci-commitlint-shellcheck branch January 26, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants