test(snakemake): allow running Snakemake 7 tests on Python 3.11+ (#700) #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-client
that referenced
this pull request
Jan 26, 2024
…#700) After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435) there is no need to avoid running Snakemake tests on Python 3.11 and 3.12, as it should be supported. Closes reanahub#655
giuseppe-steduto
force-pushed
the
snakemake-upgrade
branch
from
bbc98c6 to
47cf224
Compare
giuseppe-steduto
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #700 +/- ##
=======================================
Coverage 58.62% 58.62%
=======================================
Files 24 24
Lines 2393 2393
=======================================
Hits 1403 1403
Misses 990 990 |
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-client
that referenced
this pull request
Jan 26, 2024
…#700) After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435) there is no need to avoid running Snakemake tests on Python 3.11 and 3.12, as it should be supported. Closes reanahub#655
giuseppe-steduto
force-pushed
the
snakemake-upgrade
branch
from
47cf224 to
7ef65fa
Compare
|
Could you bump r-commons version in |
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-client
that referenced
this pull request
Feb 13, 2024
…#700) After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435) there is no need to avoid running Snakemake tests on Python 3.11 and 3.12, as it should be supported. Closes reanahub#655
giuseppe-steduto
force-pushed
the
snakemake-upgrade
branch
from
7ef65fa to
8450b00
Compare
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-client
that referenced
this pull request
Feb 21, 2024
…#700) After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435) there is no need to avoid running Snakemake tests on Python 3.11 and 3.12, as it should be supported. Closes reanahub#655
giuseppe-steduto
force-pushed
the
snakemake-upgrade
branch
from
8450b00 to
2859971
Compare
…nahub#700) After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435) there is no need to avoid running Snakemake tests on Python 3.11 and 3.12, as it should be supported. Closes reanahub#655
giuseppe-steduto
force-pushed
the
snakemake-upgrade
branch
from
2859971 to
8ad7ff1
Compare
tiborsimko
approved these changes
Feb 21, 2024
tiborsimko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435)
there is no need to avoid running Snakemake tests on Python 3.11 and
3.12, as it should be supported.
Closes #655