-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: display live logs #730
Comments
Actually a new command could create confusion to the users by offering another choice. I think it's better to be clear towards users interface-wise, i.e. offering one This would offer So I'd say let's rather implement For example, regarding |
Related to reanahub/reana#824
reana-client logs
command currently displays all available logs, with an option to use pagination (which seems to not work?). To retrieve newest logs, user would need to run the command multiple times. If all logs are returned at once, and with running the command multiple times, there would be a lot of duplicated command line output.Create new command
reana-client follow-logs
that would continuously poll for new logs and append new data to the existing output, i. e. similar totail -f
. It would follow only one workflow or one job, not both and not multiple.I think it's better to create new command instead of reusing
reana-client logs
because both commands would have different flags except for-w
(there would be confusion regarding which flags affect which behavior), and code would look more complicated.Implementation: essentially just create a
while True
loop that requests logs data (either workflow or job), calculates a diff between previous and new logs and prints the diff. If workflow or job status becomesfinished
,failed
, etc., stop the polling and exit. Otherwise sleep for--interval
seconds and repeat.Will need to implement for both Python and Go.
The text was updated successfully, but these errors were encountered: