Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): pin setuptools 70 #239

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

tiborsimko
Copy link
Member

Pin setuptools to the maximum version of 70 to allow working on Ubuntu 20.04 LTS based environments. (New versions of setuptools are not compatible.)

Note that this fix is necessary only for the maint-0.9 branches and the REANA 0.9 release series. In master we have switched to Ubuntu 24.04 LTS based environments and Python 3.12 and no pinning is necessary there.

tiborsimko added a commit to tiborsimko/reana-db that referenced this pull request Sep 2, 2024
Pin `setuptools` to the maximum version of 70 to allow working on Ubuntu
20.04 LTS based environments. (New versions of `setuptools` are not
compatible.)

Note that this fix is necessary only for the `maint-0.9` branches and
the REANA 0.9 release series. In `master` we have switched to Ubuntu
24.04 LTS based environments and Python 3.12 and no pinning is necessary
there.
@tiborsimko tiborsimko self-assigned this Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.50%. Comparing base (334ac35) to head (d8ad2f9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           maint-0.9     #239   +/-   ##
==========================================
  Coverage      74.50%   74.50%           
==========================================
  Files              7        7           
  Lines            902      902           
==========================================
  Hits             672      672           
  Misses           230      230           

@tiborsimko tiborsimko force-pushed the fix-setuptools branch 2 times, most recently from 2d44b79 to 719c384 Compare September 2, 2024 17:32
tiborsimko added a commit to tiborsimko/reana-db that referenced this pull request Sep 2, 2024
Add forgotten Python versions (3.10, 3.11, 3.12) to CI tests.
Copy link
Member

@Alputer Alputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could successsfully built the cluster and ran 4 workflows with different workflow engines

Pin `setuptools` to the maximum version of 70 to allow working on Ubuntu
20.04 LTS based environments. (New versions of `setuptools` are not
compatible.)

Note that this fix is necessary only for the `maint-0.9` branches and
the REANA 0.9 release series. In `master` we have switched to Ubuntu
24.04 LTS based environments and Python 3.12 and no pinning is necessary
there.
Add forgotten Python versions (3.10, 3.11, 3.12) to CI tests.
@tiborsimko tiborsimko changed the title chore(actions): pin setuptools 70 ci(actions): pin setuptools 70 Sep 3, 2024
@tiborsimko tiborsimko merged commit e0cba7f into reanahub:maint-0.9 Sep 3, 2024
15 checks passed
@tiborsimko tiborsimko deleted the fix-setuptools branch September 3, 2024 12:34
tiborsimko added a commit to tiborsimko/reana-db that referenced this pull request Dec 4, 2024
chore(maint-0.9): release 0.9.5 (reanahub#219)
feat(cli): add new `migrate-secret-key` command (reanahub#240)
ci(python): test more Python versions (reanahub#239)
ci(actions): pin setuptools 70 (reanahub#239)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
tiborsimko added a commit to tiborsimko/reana-db that referenced this pull request Dec 4, 2024
chore(maint-0.9): release 0.9.5 (reanahub#219)
feat(cli): add new `migrate-secret-key` command (reanahub#240)
ci(python): test more Python versions (reanahub#239)
ci(actions): pin setuptools 70 (reanahub#239)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
tiborsimko added a commit to tiborsimko/reana-db that referenced this pull request Dec 4, 2024
chore(maint-0.9): release 0.9.5 (reanahub#219)
feat(cli): add new `migrate-secret-key` command (reanahub#240)
ci(python): test more Python versions (reanahub#239)
ci(actions): pin setuptools 70 (reanahub#239)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants