Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(commitlint): check for the presence of concrete PR number #425

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

tiborsimko
Copy link
Member

  • ci(commitlint): check for the presence of concrete PR number

    Enrich commitlint checker in order to check the precise PR number in the
    commit log headline.

  • ci(shellcheck): fix exit code propagation

    Return properly the exit code status of shellcheck command when looping
    through shell script files.

tiborsimko added a commit to tiborsimko/reana-job-controller that referenced this pull request Jan 25, 2024
Return properly the exit code status of shellcheck command when looping
through shell script files.
tiborsimko added a commit to tiborsimko/reana-job-controller that referenced this pull request Jan 25, 2024
…b#425)

Enrich commitlint checker in order to check the precise PR number in the
commit log headline.
@tiborsimko tiborsimko force-pushed the ci-commitlint-shellcheck branch from 572e560 to 2bfae61 Compare January 25, 2024 11:21
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (866675b) 46.46% compared to head (35bc1c5) 46.46%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   46.46%   46.46%           
=======================================
  Files          17       17           
  Lines        1231     1231           
=======================================
  Hits          572      572           
  Misses        659      659           

Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but shellcheck has found issues in one of the scripts

Return properly the exit code status of shellcheck command when looping
through shell script files.
…b#425)

Enrich commitlint checker in order to check the precise PR number in the
commit log headline.
@tiborsimko tiborsimko force-pushed the ci-commitlint-shellcheck branch from 2bfae61 to 35bc1c5 Compare February 8, 2024 13:04
@tiborsimko tiborsimko merged commit 35bc1c5 into reanahub:master Feb 8, 2024
14 checks passed
@tiborsimko tiborsimko deleted the ci-commitlint-shellcheck branch February 8, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants