Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(commitlint): addition of commit message linter #60

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

tiborsimko
Copy link
Member

Adds commitlint to check the commit message style against agreed conventional commits configuration.

Changes script argument values to always use linter names (e.g. shellcheck).

Changes argument handling to allow only one checking action that can now accept further optional arguments.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80ff852) 100.00% compared to head (2e681a4) 100.00%.

❗ Current head 2e681a4 differs from pull request most recent head 02b3595. Consider uploading reports for the commit 02b3595 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines            7         7           
=========================================
  Hits             7         7           

tiborsimko added a commit to tiborsimko/reana-message-broker that referenced this pull request Jan 10, 2024
Adds commitlint to check the commit message style against agreed
conventional commits configuration.

Changes script argument values to always use linter names (e.g.
shellcheck).

Changes argument handling to allow only one checking action that can now
accept further optional arguments.
tiborsimko added a commit to tiborsimko/reana-message-broker that referenced this pull request Jan 10, 2024
tiborsimko added a commit to tiborsimko/reana-message-broker that referenced this pull request Jan 10, 2024
tiborsimko added a commit to tiborsimko/reana-message-broker that referenced this pull request Jan 11, 2024
Adds commitlint to check the commit message style against agreed
conventional commits configuration.

Changes script argument values to always use linter names (e.g.
shellcheck).

Changes argument handling to allow only one checking action that can now
accept further optional arguments.
tiborsimko added a commit to tiborsimko/reana-message-broker that referenced this pull request Jan 11, 2024
Adds commitlint to check the commit message style against agreed
conventional commits configuration.

Changes script argument values to always use linter names (e.g.
shellcheck).

Changes argument handling to allow only one checking action that can now
accept further optional arguments.
@tiborsimko tiborsimko merged commit 02b3595 into reanahub:master Jan 12, 2024
12 checks passed
@tiborsimko tiborsimko deleted the commitlint branch January 12, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants