Add compute4punch compute_backend #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giffels
force-pushed
the
add/compute4punch-support
branch
from
df74aad to
89bce51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maint-0.9 #780 +/- ##
==========================================
Coverage 18.15% 18.15%
==========================================
Files 26 26
Lines 2478 2478
==========================================
Hits 450 450
Misses 2028 2028
|
|
Hi @tiborsimko , what is the situation with this integration, I have a branch with slurm integration as well, where to start merging them ? |
Hi @arm2arm The integration was delayed due to some illnesses and absences on our end... We are getting to it this week and the next. BTW some of the remarks made by @mdonadoni in @giffels's pull requests were still not fully closed and may be important, such as a possible code injection? Would you be able to look into them before the integration? |
mdonadoni
pushed a commit
to giffels/reana
that referenced
this pull request
Jul 4, 2024
mdonadoni
force-pushed
the
add/compute4punch-support
branch
from
89bce51 to
41792fe
Compare
mdonadoni
pushed a commit
to giffels/reana
that referenced
this pull request
Jul 4, 2024
mdonadoni
force-pushed
the
add/compute4punch-support
branch
from
41792fe to
776ec76
Compare
tiborsimko
approved these changes
Jul 4, 2024
mdonadoni
force-pushed
the
add/compute4punch-support
branch
from
776ec76 to
c2f490b
Compare
tiborsimko
added a commit
to tiborsimko/reana
that referenced
this pull request
Aug 29, 2024
build(helm): add support for Kubernetes 1.31 (reanahub#822) ci(python): pin setuptools 70 (reanahub#822) feat(config): add Compute4PUNCH backend (reanahub#780) Note: The merge commit removes the changes related to pinning `setuptools` to version 70, because this was only necessary for the `maint-0.9` branches.
tiborsimko
added a commit
to tiborsimko/reana
that referenced
this pull request
Aug 29, 2024
build(helm): add support for Kubernetes 1.31 (reanahub#822) ci(python): pin setuptools 70 (reanahub#822) feat(config): add Compute4PUNCH backend (reanahub#780) Note: The merge commit removes the changes related to pinning `setuptools` to version 70, because this was only necessary for the `maint-0.9` branches.
jlemesh
pushed a commit
to jlemesh/reana
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the new
compute4punchcompute backend to the list of available compute backends. Thecompute4punchcompute backend is currently implemented in reanahub/reana-job-controller#430.