-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reana-dev): add git-aggregate-changelog
(#789)
#789
Conversation
67485c2
to
1dc8d2a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #789 +/- ##
==========================================
- Coverage 18.56% 18.15% -0.41%
==========================================
Files 26 26
Lines 2375 2478 +103
==========================================
+ Hits 441 450 +9
- Misses 1934 2028 +94
|
|
||
@git_commands.command(name="git-aggregate-changelog") | ||
@click.option( | ||
"--previous-reana-client", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could enrich the CLI later so that users could pass -c
as to the other reana-dev
commands. This might be useful to generate quickly an overview of all the changes from version X to version Y for example.
Such a CLI interface could look something like:
-c r-client -- since-version 0.9.2
-c r-client --since-date=2023-01-01
Or, by analogy with git-checkout-pr
, we should probably have a tuple of values to allow assembling several components:
-b r-client 0.9.1 -b r-j-controller 0.9.0
Just some wild musings for later, not for now.
That said, if we do decide to go for this one day, to allow aggregating news from more than one release, then the CLI option name could change, so perhaps we could forward-name the option to be something like --since-reana-client-version 0.9.2
instead of --previous-reana-client
? 🤔
"for the last REANA release?", | ||
required=True, | ||
) | ||
def get_aggregate_changelog(previous_reana_client): # noqa: D301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely 👍
One functionality comment that would be good to do already now is to present the aggregation of components following their alphabetical naming order, so that the order is predictible.
(Currently I'm seeing r-w-e-yadage being printed before r-w-e-snakemake for example.)
1dc8d2a
to
28ad849
Compare
28ad849
to
5763974
Compare
5763974
to
6210b11
Compare
No description provided.