-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): add NodePort services for debugging (#812) #812
fix(helm): add NodePort services for debugging (#812) #812
Conversation
8292679
to
6336b59
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #812 +/- ##
=======================================
Coverage 18.15% 18.15%
=======================================
Files 26 26
Lines 2478 2478
=======================================
Hits 450 450
Misses 2028 2028
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well and looks good to me! Services were all NodePort
in the past, but they were then changed to ClusterIP
in #675, and we didn't update the reana-dev scripts properly. I have tested that I can access rabbitmq's UI and the database.
Just one thing left, could you add your ORCID to AUTHORS.md
(in alphabetical order) ?
aa0677a
to
29d1fcd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
29d1fcd
to
9698c63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Current port mapping from Kubernetes service to localhosts for RabbitMQ debugging does not work (RabbitMQ has a nice UI that allows inspecting queues and messages). The reason is that
reana-message-broker
usesClusterIP
service instead ofNodePort
, which does not allow access from outside of the cluster (reana-mail
uses NodePort and works fine). I can think of two ways of fixing it - either delete broken code fromcluster.py
and usekubectl port-forward
, or add additional debugNodePort
service to Helm chart (we already havedebug.enabled
flag). This PR implements the latter, as it simplifies running REANA cluster in debugging mode.Also adding debug service for PostgreSQL which would allow connecting to it via PostgreSQL client on host machine.
Kubernetes services before:
Kubernetes services after: