Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide morph-logger module #25

Open
baransu opened this issue Oct 29, 2019 · 2 comments · May be fixed by #26
Open

Provide morph-logger module #25

baransu opened this issue Oct 29, 2019 · 2 comments · May be fixed by #26

Comments

@baransu
Copy link

baransu commented Oct 29, 2019

It would be amazing to have some basic logging middleware available out of the box. Maybe not something fully featured like https://github.com/expressjs/morgan but basic logger middleware from https://github.com/reason-native-web/morph-hello-world-pesy-template/blob/master/library/Middleware.re would be a good start.

@baransu baransu linked a pull request Oct 29, 2019 that will close this issue
2 tasks
@ulrikstrid
Copy link
Collaborator

ulrikstrid commented Oct 30, 2019

I like this a lot. I had a realization that the middleware logger lies a bit so we might have to add some callbacks for logging or some other way of integrating logging.
But I think that a good middleware logger is something that would be really nice to have.

@baransu
Copy link
Author

baransu commented Oct 30, 2019

In general, it would be great to provide a wrapper around logs with more customization options like something more powerful than console backend. Not sure how much logs can do at its own but I imagine something like Elixir logger: https://hexdocs.pm/logger/Logger.html not especially for a server but for whole application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants