Skip to content

update tabBarComponent to tabBar#33

Merged
MoOx merged 2 commits intorescript-react-native:masterfrom
Freddy03h:patch-1
Jun 28, 2020
Merged

update tabBarComponent to tabBar#33
MoOx merged 2 commits intorescript-react-native:masterfrom
Freddy03h:patch-1

Conversation

@Freddy03h
Copy link
Member

tabBarComponent doesn't exist in the react-navigation props, it's tabBar only.

For now, it compile to this and it doesn't work:

return React.createElement($$Navigator.make, {
              children: children,
              tabBarComponent: CustomTopTabBar$TopTabBar,
              tabBarOptions: tabBarOptions
            });

@MoOx MoOx merged commit 425b950 into rescript-react-native:master Jun 28, 2020
@Freddy03h
Copy link
Member Author

Thank you!

@MoOx
Copy link
Member

MoOx commented Jun 29, 2020

No, thank YOU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants